summary refs log tree commit diff
path: root/drivers/haptic
diff options
context:
space:
mode:
authorDrashna Jaelre <drashna@live.com>2019-11-15 14:27:46 -0800
committerJoel Challis <git@zvecr.com>2019-11-15 22:27:46 +0000
commitf6b5f6db7665512cece0223ce4d19c5b17455ef4 (patch)
tree0eb1313ba5d706819321b32effd9f5dc6d9fee62 /drivers/haptic
parent381b73fcac169338a1dcf433694108a29870a57e (diff)
Improvements to Solenoid feature (#7369)
* Error out when Solenid pin is not defined

Instead of defaulting to a (literally) random pin, error out instead.  Because this pin may be used, or because that pin may not be exposed, or may not exist.

* Remove 'SOLENOID_ACTIVE' setting since it's not used

* Update documentation
Diffstat (limited to 'drivers/haptic')
-rw-r--r--drivers/haptic/solenoid.h6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/haptic/solenoid.h b/drivers/haptic/solenoid.h
index 53dc626e33..dd6ececa68 100644
--- a/drivers/haptic/solenoid.h
+++ b/drivers/haptic/solenoid.h
@@ -29,12 +29,8 @@
 #    define SOLENOID_MIN_DWELL 4
 #endif
 
-#ifndef SOLENOID_ACTIVE
-#    define SOLENOID_ACTIVE false
-#endif
-
 #ifndef SOLENOID_PIN
-#    define SOLENOID_PIN F6
+#    error SOLENOID_PIN not defined
 #endif
 
 void solenoid_buzz_on(void);