summary refs log tree commit diff
diff options
context:
space:
mode:
authorGastón Jorquera <email@gaston.life>2021-11-28 12:28:15 -0800
committerGitHub <noreply@github.com>2021-11-28 20:28:15 +0000
commitb29b4827413798abc8dc2b81a497bda4ab6cefb3 (patch)
tree960561b5c31f7201833bafa8e364f1d03e8491ca
parent9beee82825c52a4618d3cb238c399d9e8a638f42 (diff)
Add TRNS to LOWER layer (#15288)
This commit makes the mode keys transparent in the LOWER layer instead
of disabled.

Before this commit, the following sequence of key presses `LGUI+LOWER+l`
would translate into `Cmd+right` in macOS and, therefore, move the
cursor to the end of line.

But, pressing `LOWER+LGUI+l` would completely ignore the `LGUI` and,
therefore, move the cursor one letter to the right.

With this change, pressing `LOWER+LGUI+l` produces the same result as
`LGUI+LOWER+l`.

This is also true for multiple other combinations, like
`RALT+SHIFT+LOWER+l`, `LOWER+RALT+SHIFT+l`, `SHIFT+LOWER+RALT+l`, etc.

Co-authored-by: Gaston Jorquera <gjorquera@gmail.com>
-rw-r--r--keyboards/lily58/keymaps/gaston/keymap.c8
-rw-r--r--keyboards/lily58/keymaps/gaston/readme.md8
2 files changed, 8 insertions, 8 deletions
diff --git a/keyboards/lily58/keymaps/gaston/keymap.c b/keyboards/lily58/keymaps/gaston/keymap.c
index 234b283a91..321b225c02 100644
--- a/keyboards/lily58/keymaps/gaston/keymap.c
+++ b/keyboards/lily58/keymaps/gaston/keymap.c
@@ -41,10 +41,10 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
 
 [_LOWER] = LAYOUT(
     KC_ESC,  KC_F1,   KC_F2,   KC_F3,   KC_F4,   KC_F5,                     KC_F6,   KC_F7,   KC_F8,   KC_F9,   KC_F10,  KC_F11,
-    XXXXXXX, XXXXXXX, KC_MUTE, KC_VOLD, KC_VOLU, XXXXXXX,                   KC_HOME, KC_PGDN, KC_PGUP, KC_END,  XXXXXXX, KC_F12,
-    XXXXXXX, XXXXXXX, KC_MPRV, KC_MPLY, KC_MNXT, XXXXXXX,                   KC_LEFT, KC_DOWN, KC_UP,   KC_RGHT, XXXXXXX, XXXXXXX,
-    XXXXXXX, XXXXXXX, XXXXXXX, KC_BRID, KC_BRIU, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_INS,  KC_DEL,  XXXXXXX, XXXXXXX, XXXXXXX,
-                               XXXXXXX, XXXXXXX, XXXXXXX, KC_TRNS, KC_TRNS, XXXXXXX, XXXXXXX, XXXXXXX
+    KC_TRNS, XXXXXXX, KC_MUTE, KC_VOLD, KC_VOLU, XXXXXXX,                   KC_HOME, KC_PGDN, KC_PGUP, KC_END,  XXXXXXX, KC_F12,
+    KC_TRNS, XXXXXXX, KC_MPRV, KC_MPLY, KC_MNXT, XXXXXXX,                   KC_LEFT, KC_DOWN, KC_UP,   KC_RGHT, XXXXXXX, XXXXXXX,
+    KC_TRNS, XXXXXXX, XXXXXXX, KC_BRID, KC_BRIU, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_INS,  KC_DEL,  XXXXXXX, XXXXXXX, XXXXXXX,
+                               KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, XXXXXXX, XXXXXXX, XXXXXXX
 ),
 
 [_MOUSE] = LAYOUT(
diff --git a/keyboards/lily58/keymaps/gaston/readme.md b/keyboards/lily58/keymaps/gaston/readme.md
index 2d28be00af..8edd92cc3f 100644
--- a/keyboards/lily58/keymaps/gaston/readme.md
+++ b/keyboards/lily58/keymaps/gaston/readme.md
@@ -38,13 +38,13 @@ The main characteristics of this keymap are:
 ,-----------------------------------------.                    ,-----------------------------------------.
 | ESC  |  F1  |  F2  |  F3  |  F4  |  F5  |                    |  F6  |  F7  |  F8  |  F9  | F10  | F11  |
 |------+------+------+------+------+------|                    |------+------+------+------+------+------|
-|      |      | MUTE | VOLD | VOLU |      |                    | HOME | PGDN | PGUP | END  |      | F12  |
+| TRNS |      | MUTE | VOLD | VOLU |      |                    | HOME | PGDN | PGUP | END  |      | F12  |
 |------+------+------+------+------+------|                    |------+------+------+------+------+------|
-|      |      | MPRV | MPLY | MNXT |      |-------.    ,-------| LEFT | DOWN | UP   | RGHT |      |      |
+| TRNS |      | MPRV | MPLY | MNXT |      |-------.    ,-------| LEFT | DOWN | UP   | RGHT |      |      |
 |------+------+------+------+------+------|       |    |       |------+------+------+------+------+------|
-|      |      |      | BRID | BRIU |      |-------|    |-------|      | INS  | DEL  |      |      |      |
+| TRNS |      |      | BRID | BRIU |      |-------|    |-------|      | INS  | DEL  |      |      |      |
 `-----------------------------------------/       /     \       \----------------------------------------'
-                  |      |      |      | / TRNS  /       \ TRNS  \  |      |      |      |
+                  | TRNS | TRNS | TRNS | / TRNS  /       \ TRNS  \  |      |      |      |
                   |      |      |      |/       /         \       \ |      |      |      |
                   `----------------------------'           '-----------------------------'
 ```