diff options
| author | mrfaptastic <12006953+mrfaptastic@users.noreply.github.com> | 2023-01-21 11:37:28 +0000 |
|---|---|---|
| committer | mrfaptastic <12006953+mrfaptastic@users.noreply.github.com> | 2023-01-21 11:37:28 +0000 |
| commit | 9eacd9a656c565e0fd92a926e58501e5843118d0 (patch) | |
| tree | 8251e379e49e9c6031f00e3da24a8d1ef7f60e7e /src | |
| parent | ff5d69a4fdc82bb23cac45188d115edec7e0ae7f (diff) | |
Cleanup
Diffstat (limited to 'src')
| -rw-r--r-- | src/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp | 27 | ||||
| -rw-r--r-- | src/ESP32-HUB75-MatrixPanel-I2S-DMA.h | 2 |
2 files changed, 10 insertions, 19 deletions
diff --git a/src/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp b/src/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp index 2bb4da0..fb17dab 100644 --- a/src/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp +++ b/src/ESP32-HUB75-MatrixPanel-I2S-DMA.cpp @@ -591,8 +591,10 @@ void MatrixPanel_I2S_DMA::clearFrameBuffer(bool _buff_id){ * @param brt - brightness level from 0 to row_width * @param _buff_id - buffer id to control */ +/* +// Depreciated void MatrixPanel_I2S_DMA::brtCtrlOE(int brt, const bool _buff_id){ - /* + if (!initialized) return; @@ -666,9 +668,8 @@ void MatrixPanel_I2S_DMA::brtCtrlOE(int brt, const bool _buff_id){ } while(row_idx); - */ } - + */ @@ -682,21 +683,8 @@ void MatrixPanel_I2S_DMA::brtCtrlOEv2(uint8_t brt, const int _buff_id) { if (!initialized) return; -/* - int x_coord_oe_adjust_stop_point = PIXELS_PER_ROW - - - if (brt > PIXELS_PER_ROW - (MAX_LAT_BLANKING + 2)) // can't control values larger than (row_width - latch_blanking) to avoid ongoing issues being raised about brightness and ghosting. - brt = PIXELS_PER_ROW - (MAX_LAT_BLANKING + 2); // +2 for a bit of buffer... - - if (brt < 0) - brt = 0; -*/ - - - //Serial.println(brightness_in_x_pixels, DEC); uint8_t _blank = m_cfg.latch_blanking; // don't want to inadvertantly blast over this - // start with iterating all rows in dma_buff structure int row_idx = dma_buff.rowBits.size(); do { @@ -745,10 +733,13 @@ void MatrixPanel_I2S_DMA::brtCtrlOEv2(uint8_t brt, const int _buff_id) { row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] |= BIT_OE; // Disable output after this point. } + + // Note: Old code below from 'brtCtrlOE' + + /* // clear OE bit for all other pixels (that is, turn on output) - //row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] &= BITMASK_OE_CLEAR; + row[ESP32_TX_FIFO_POSITION_ADJUST(x_coord)] &= BITMASK_OE_CLEAR; - /* // Brightness control via OE toggle - disable matrix output at specified x_coord if((colouridx > lsbMsbTransitionBit || !colouridx) && ((x_coord) >= brt)){ diff --git a/src/ESP32-HUB75-MatrixPanel-I2S-DMA.h b/src/ESP32-HUB75-MatrixPanel-I2S-DMA.h index 8175ecc..66ddc77 100644 --- a/src/ESP32-HUB75-MatrixPanel-I2S-DMA.h +++ b/src/ESP32-HUB75-MatrixPanel-I2S-DMA.h @@ -718,7 +718,7 @@ class MatrixPanel_I2S_DMA { * @param brt - brightness level from 0 to row_width * @param _buff_id - buffer id to control */ - void brtCtrlOE(int brt, const bool _buff_id=0); + //void brtCtrlOE(int brt, const bool _buff_id=0); /** * @brief - reset OE bits in DMA buffer in a way to control brightness |