aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormrfaptastic <12006953+mrfaptastic@users.noreply.github.com>2020-11-02 23:16:51 +0000
committermrfaptastic <12006953+mrfaptastic@users.noreply.github.com>2020-11-02 23:16:51 +0000
commit12fde7fa64736fd3bcb3120313e8def6d8211668 (patch)
tree691286206024218f074db4b34c3be8cd2e695c17
parent511b6e50f89212fed393024746dd5a7717b26d39 (diff)
Minor changes
-rw-r--r--ESP32-RGB64x32MatrixPanel-I2S-DMA.cpp5
-rw-r--r--ESP32-RGB64x32MatrixPanel-I2S-DMA.h19
2 files changed, 10 insertions, 14 deletions
diff --git a/ESP32-RGB64x32MatrixPanel-I2S-DMA.cpp b/ESP32-RGB64x32MatrixPanel-I2S-DMA.cpp
index cfabe53..4367250 100644
--- a/ESP32-RGB64x32MatrixPanel-I2S-DMA.cpp
+++ b/ESP32-RGB64x32MatrixPanel-I2S-DMA.cpp
@@ -370,6 +370,11 @@ void RGB64x32MatrixPanel_I2S_DMA::configureDMA(int r1_pin, int g1_pin, int b1_
#if SERIAL_DEBUG
Serial.printf("configureDMA(): Configured LL structure. %d DMA Linked List descriptors populated.\r\n", current_dmadescriptor_offset);
+
+ if ( desccount != current_dmadescriptor_offset)
+ {
+ Serial.printf("configureDMA(): ERROR! Expected descriptor count of %d != actual DMA descriptors of %d!\r\n", desccount, current_dmadescriptor_offset);
+ }
#endif
dmadesc_a[desccount-1].eof = 1;
diff --git a/ESP32-RGB64x32MatrixPanel-I2S-DMA.h b/ESP32-RGB64x32MatrixPanel-I2S-DMA.h
index 47346e8..08bd064 100644
--- a/ESP32-RGB64x32MatrixPanel-I2S-DMA.h
+++ b/ESP32-RGB64x32MatrixPanel-I2S-DMA.h
@@ -24,22 +24,13 @@
* All of this is memory permitting of course (dependant on your sketch etc.) ...
*
*/
-#ifndef MATRIX_HEIGHT
- #define MATRIX_HEIGHT 32
-#endif
-
-#ifndef MATRIX_WIDTH
- #define MATRIX_WIDTH 64
-#endif
+#define MATRIX_WIDTH 64 // CHANGE THIS VALUE IF CHAINING
+#define MATRIX_HEIGHT 32 // CHANGE THIS VALUE ONLY IF USING 64px HIGH panel with E PIN
-#ifndef PIXEL_COLOR_DEPTH_BITS
- #define PIXEL_COLOR_DEPTH_BITS 8 // 8bit per RGB color = 24 bit/per pixel, reduce to save RAM
-#endif
-
-#ifndef MATRIX_ROWS_IN_PARALLEL
- #define MATRIX_ROWS_IN_PARALLEL 2 // Don't change this unless you know what you're doing
-#endif
+/* Best to keep these values as is. */
+#define PIXEL_COLOR_DEPTH_BITS 8 // 8bit per RGB color = 24 bit/per pixel, reduce to save RAM
+#define MATRIX_ROWS_IN_PARALLEL 2 // Don't change this unless you know what you're doing
/* ESP32 Default Pin definition. You can change this, but best if you keep it as is and provide custom pin mappings
* as part of the begin(...) function.