From 3f0fdc72bcbdc929f5fd95653bf6cb2c4a0bcb88 Mon Sep 17 00:00:00 2001 From: Lukaswnd Date: Sat, 16 Dec 2023 23:25:31 +0100 Subject: fix Adafruit_GFX override setRotation The Adafruit_GFX uses setRotation(uint8_t), while the virtual matrix display uses setRotation(int). Therefore there is no implicit override and if you call the function either with an uint8_t or from an Adafruit_GFX* the overloaded funtion is not called --- src/ESP32-VirtualMatrixPanel-I2S-DMA.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ESP32-VirtualMatrixPanel-I2S-DMA.h b/src/ESP32-VirtualMatrixPanel-I2S-DMA.h index ebac204..2738599 100644 --- a/src/ESP32-VirtualMatrixPanel-I2S-DMA.h +++ b/src/ESP32-VirtualMatrixPanel-I2S-DMA.h @@ -112,7 +112,7 @@ public: // equivalent methods of the matrix library so it can be just swapped out. void drawPixel(int16_t x, int16_t y, uint16_t color); // overwrite adafruit implementation void fillScreen(uint16_t color); // overwrite adafruit implementation - void setRotation(int rotate); // overwrite adafruit implementation + void setRotation(uint8_t rotate); // overwrite adafruit implementation void fillScreenRGB888(uint8_t r, uint8_t g, uint8_t b); void clearScreen() { display->clearScreen(); } @@ -472,7 +472,7 @@ inline void VirtualMatrixPanel::fillScreen(CRGB color) } #endif -inline void VirtualMatrixPanel::setRotation(int rotate) +inline void VirtualMatrixPanel::setRotation(uint8_t rotate) { if(rotate < 4 && rotate >= 0) _rotate = rotate; -- cgit v1.3.1